fix: deprecate max-turns and move timeout-minutes to YAML job property#138
Merged
Conversation
- max-turns was specific to Claude Code and is not supported by Copilot CLI. It is now ignored at compile time with a deprecation warning. Front matter parsing is preserved for backwards compatibility. - timeout-minutes no longer emits --max-timeout CLI arg. Instead it generates timeoutInMinutes on the PerformAgenticTask job in both standalone and 1ES templates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🔍 Rust PR ReviewSummary: Looks good overall — the deprecation/migration is clean and well-tested. One bug in the zero-value warning message. Findings🐛 Bugs / Logic Issues
✅ What Looks Good
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-turns: Deprecated — was specific to Claude Code and is not supported by Copilot CLI. Front matter parsing is preserved for backwards compatibility, but a warning is emitted at compile time and the value is no longer passed as a CLI arg.timeout-minutes: No longer emits--max-timeoutas a Copilot CLI arg. Instead, it generatestimeoutInMinuteson thePerformAgenticTaskjob in both standalone and 1ES pipeline templates.Changes
src/compile/types.rs— Markmax_turnsas deprecated in docssrc/compile/common.rs— Emit deprecation warning formax-turns, addgenerate_job_timeout(), update testssrc/compile/standalone.rs/onees.rs— Wire up{{ job_timeout }}replacementtemplates/base.yml/1es-base.yml— Add{{ job_timeout }}markerAGENTS.md/prompts/— Update documentation